Bug #1119
Default conf.d file for transmission-daemon makes it ignore config file settings.
| Status: | Closed | Start date: | 05/01/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | Aports | |||
| Target version: | - | |||
| Affected versions: |
Description
There is download-dir setting in /var/lib/transmission-daemon/.config/settings.json. But transmission-daemon resets it to /var/lib/transmission if you start it with init script.
This happens because default /etc/conf.d/transmission-daemon reads:
TD_OPTS="-f -g /var/lib/transmission/.config -w /var/lib/transmission"
-w key sets download dir, ignoring one set in settings file. More than that, settings file gets updated, so that download-dir option is set to the path specified in /etc/conf.d/transmission-daemon.
I am not sure if this was intended behavior, but it is really very unexpected, and I've spend a lot of time trying to figure out why transmission resets download-dir.
Associated revisions
main/transmission: upgrade to 2.52 and sync init.d script
Copy init.d script from gentoo.
fixes #1119
main/transmission: move transmission homedir to /var/lib
fixes #1119
main/transmission: upgrade to 2.52 and sync init.d script
Copy init.d script from gentoo.
fixes #1119
main/transmission: move transmission homedir to /var/lib
fixes #1119
History
#1
Updated by Natanael Copa 12 months ago
- Category set to Aports
I copied the init.d scripts from gentoo.
Fix is in edge currently. If upgrading "just works" then I think we should backport this for v2.4. If it does not "just work" then I think we might want consider backporting anyways.
Could you please test it? Should come with transmission-2.52 upgrade.
#2
Updated by Natanael Copa 12 months ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset 52268079a47baae6e6fa5924acf71e88e12d2d12.
#3
Updated by Igor Tarasov 12 months ago
Seems to be ok for me.
#4
Updated by Igor Tarasov 12 months ago
Well, no. There seems to be some issues:
It has another default config directory (not /var/lib/transmission/.config, but /var/transmission/config), also, new config files are written as transmission user home dir is /var/transmission, but it is /var/lib/transmission (created in pre-install script).
Also, due to everything mentioned above, it does not see config file, and cannot download.
My prior comment was as it worked on old config files.
#5
Updated by Natanael Copa 12 months ago
- Status changed from Resolved to New
- % Done changed from 100 to 50
reopening
#6
Updated by Natanael Copa 12 months ago
moved it to /var/lib, where it belongs, and added a post-upgrade script that moves .config to config + adds a compat symlink.
Please test.
Thanks!
#7
Updated by Natanael Copa 12 months ago
- Status changed from New to Resolved
- % Done changed from 50 to 100
Applied in changeset dca0d8f72ebf75f3e425b356dafd93babde34a0d.
#8
Updated by Igor Tarasov 12 months ago
Gonna test it now, but isn't .config is more proper name? ~/.config is freedesktop.org standard for storing config files. Also, default transmission-daemon config directory is ~/.config/transmission-daemon: https://trac.transmissionbt.com/wiki/ConfigFiles
#9
Updated by Natanael Copa 12 months ago
- Status changed from Resolved to Feedback
And /home is a proper location for home dirs, not /var/lib/.
I think for system daemon users we don't need to "hide" it by prefixing it with .
But I have not strong opinions here. If you strongly feel for using .config, then lets do so. (and it would save us for the upgrade script = slightly faster upgrades)
Do you think I should rename it back to .config?
#10
Updated by Igor Tarasov 12 months ago
No. I also do have no strong opinion at this point.
#11
Updated by Natanael Copa 12 months ago
- Status changed from Feedback to Resolved
Applied in changeset d660cc97bbd08121d6d2e930046903e01bea85b4.
#12
Updated by Natanael Copa 12 months ago
Applied in changeset 66f48048002c91b7cc1cfa5b62f4f697038077a8.
#13
Updated by Natanael Copa 12 months ago
- Status changed from Resolved to Closed