Project

General

Profile

Bug #9644

Lua 5.3 history handling in interactive mode is unavaiable

Added by get muzui 5 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
11/15/2018
Due date:
% Done:

100%

Estimated time:
Affected versions:
Security IDs:

Description

How reproduce this bug?

Run `lua` command, type `print("hello")` and hit enter button, then use "<UP>" button to get previous command, but nothing happend.

From the package "lua5.3" build files https://git.alpinelinux.org/cgit/aports/tree/main/lua5.3?h=3.8-stable

I notice Alpine use linenoise instead of GNU readline, but the patch https://git.alpinelinux.org/cgit/aports/tree/main/lua5.3/linenoise.patch?h=3.8-stable is outdated.

Take a look a Lua source https://github.com/lua/lua/blob/v5-3-4/lua.c#L85 the code had changed to `lua_saveline(L,line)`, the changing since 5.3.1, see https://github.com/lua/lua/commit/57c0db219b9ee48d951adf68a577b4eec5309e57

After I changed it to `#define lua_saveline(L,line) ((void)L, linenoiseHistoryAdd(line))` and recompile, the history handing work again.

Associated revisions

Revision cde8024d (diff)
Added by Natanael Copa 4 months ago

main/lua5.3: fix linenoise patch

ref #9644

Revision fc230a5b (diff)
Added by Natanael Copa 4 months ago

main/lua5.3: fix linenoise patch

fixes #9644

(cherry picked from commit cde8024d0da937f5f7b0b9b329c1f27c14b00308)

History

#1 Updated by Natanael Copa 5 months ago

  • Target version set to 3.8.2

Thanks for a good report.

#2 Updated by Natanael Copa 4 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#3 Updated by Natanael Copa 4 months ago

  • Status changed from Resolved to Closed

#4 Updated by Samsun Rock about 1 month ago

Hello friends, i am so glad to see there http://fixwindows10connections.com present information because they are really effective from wireless connection in windows device, after using this function you can access our desktop things in any other computer.

Also available in: Atom PDF